-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: downgrade custom resources to Node 12 #16818
Conversation
Some AWS regions do not yet support the Node 14.x runtime for Lambda, which
makes it challenging to use anything that involves a vended custom resource that
uses it.
Downgrading all those resources to use Node 12.x instead, which is available in
all regions where Lambda is, and hence provides better coverage and usability.
Fixes cdklabs/cdk-ops#1686
@RomainMuller is it possible to opt out from this change? We try to very closely follow LTS schedules of different platforms and keep all of our systems up-to-date which means that we have already moved to NodeJs 14 (https://nodejs.org/en/about/releases/) and our systems will generate (unneeded) alerts for teams if we see any "outdated" resource platforms deployed |
Strictly speaking, nothing prevents a future CustomResource you'd transparently be using from using an "outdated" runtime. As much as I'd like to make this configurable/opt-in, that sounds like it might end up not being very clean (what about non-JS runtimes? What if the runtime you forward-to has incompatibilities with the one that we tested with?) |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Some AWS regions do not yet support the Node 14.x runtime for Lambda, which
makes it challenging to use anything that involves a vended custom resource that
uses it.
Downgrading all those resources to use Node 12.x instead, which is available in
all regions where Lambda is, and hence provides better coverage and usability.
Fixes cdklabs/cdk-ops#1686
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Some AWS regions do not yet support the Node 14.x runtime for Lambda, which
makes it challenging to use anything that involves a vended custom resource that
uses it.
Downgrading all those resources to use Node 12.x instead, which is available in
all regions where Lambda is, and hence provides better coverage and usability.
Fixes cdklabs/cdk-ops#1686
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Some AWS regions do not yet support the Node 14.x runtime for Lambda, which
makes it challenging to use anything that involves a vended custom resource that
uses it.
Downgrading all those resources to use Node 12.x instead, which is available in
all regions where Lambda is, and hence provides better coverage and usability.
Fixes cdklabs/cdk-ops#1686
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license