Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade custom resources to Node 12 #16818

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Conversation

RomainMuller
Copy link
Contributor

Some AWS regions do not yet support the Node 14.x runtime for Lambda, which
makes it challenging to use anything that involves a vended custom resource that
uses it.

Downgrading all those resources to use Node 12.x instead, which is available in
all regions where Lambda is, and hence provides better coverage and usability.

Fixes cdklabs/cdk-ops#1686


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Some AWS regions do not yet support the Node 14.x runtime for Lambda, which
makes it challenging to use anything that involves a vended custom resource that
uses it.

Downgrading all those resources to use Node 12.x instead, which is available in
all regions where Lambda is, and hence provides better coverage and usability.

Fixes cdklabs/cdk-ops#1686
@RomainMuller RomainMuller requested a review from a team October 6, 2021 09:52
@RomainMuller RomainMuller self-assigned this Oct 6, 2021
@gitpod-io
Copy link

gitpod-io bot commented Oct 6, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 6, 2021
@markusl
Copy link
Contributor

markusl commented Oct 6, 2021

@RomainMuller is it possible to opt out from this change? We try to very closely follow LTS schedules of different platforms and keep all of our systems up-to-date which means that we have already moved to NodeJs 14 (https://nodejs.org/en/about/releases/) and our systems will generate (unneeded) alerts for teams if we see any "outdated" resource platforms deployed

@RomainMuller
Copy link
Contributor Author

@RomainMuller is it possible to opt out from this change? We try to very closely follow LTS schedules of different platforms and keep all of our systems up-to-date which means that we have already moved to NodeJs 14 (https://nodejs.org/en/about/releases/) and our systems will generate (unneeded) alerts for teams if we see any "outdated" resource platforms deployed

Strictly speaking, nothing prevents a future CustomResource you'd transparently be using from using an "outdated" runtime. As much as I'd like to make this configurable/opt-in, that sounds like it might end up not being very clean (what about non-JS runtimes? What if the runtime you forward-to has incompatibilities with the one that we tested with?)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 0eb1c31
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit deb0d4d into master Oct 6, 2021
@mergify mergify bot deleted the rmuller/cr-lambda-node12 branch October 6, 2021 13:08
@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

njlynch pushed a commit that referenced this pull request Oct 11, 2021
Some AWS regions do not yet support the Node 14.x runtime for Lambda, which
makes it challenging to use anything that involves a vended custom resource that
uses it.

Downgrading all those resources to use Node 12.x instead, which is available in
all regions where Lambda is, and hence provides better coverage and usability.

Fixes cdklabs/cdk-ops#1686


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Some AWS regions do not yet support the Node 14.x runtime for Lambda, which
makes it challenging to use anything that involves a vended custom resource that
uses it.

Downgrading all those resources to use Node 12.x instead, which is available in
all regions where Lambda is, and hence provides better coverage and usability.

Fixes cdklabs/cdk-ops#1686


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants